[PATCH] D156468: [lld-macho] Fixed crashes when linking with incompatible-arch archives/

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 9 13:21:24 PDT 2023


thakis added a comment.

Your fix is in now, so that's ok, but there was a 2-day window between things being known-bad and the fix landing. This causes needless work (see e.g. https://bugs.chromium.org/p/chromium/issues/detail?id=1471633). Reverting is usually much faster than fixing, so please default to revert-first to keep trunk green (unless you have a fix that's ready to land as quickly as the revert).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156468/new/

https://reviews.llvm.org/D156468



More information about the llvm-commits mailing list