[PATCH] D157517: [AArch64][SVE] Add asm predicate constraint Uph

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen accepted this revision.
sdesmalen added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:9984-9990
+  if (Constraint == "Uph")
+    return PredicateConstraint::Uph;
+  else if (Constraint == "Upl")
+    return PredicateConstraint::Upl;
+  else if (Constraint == "Upa")
+    return PredicateConstraint::Upa;
+  return PredicateConstraint::Invalid;
----------------
nit: you could choose to use a StringSwitch for this, e.g.

  return StringSwitch<PredicateConstraint>(Constraint)
                 .Case("Uph", PredicateConstraint::Uph)
                 .Case("Upl", PredicateConstraint::Upl)
                 .Case("Upa", PredicateConstraint::Upa)
                 .Default(PredicateConstraint::Invalid);


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157517/new/

https://reviews.llvm.org/D157517