[PATCH] D157451: [AMDGPU] Do not deduce access qualifiers from IR attributes
Changpeng Fang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 9 12:21:23 PDT 2023
cfang added inline comments.
================
Comment at: llvm/test/CodeGen/AMDGPU/hsa-metadata-deduce-ro-arg-v3.ll:2
; RUN: llc -mtriple=amdgcn-amd-amdhsa -filetype=obj -o - < %s | llvm-readelf --notes - | FileCheck %s
; CHECK: - .args:
----------------
arsenm wrote:
> From the test name, was this supposed to be inferred? Are there non-introspection uses for the access metadata?
I am not sure about the actual uses. But apparently the conformance test get_kernel_arg_info checks that.
Do you want to change the name (remove deduce? ) of these two tests?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157451/new/
https://reviews.llvm.org/D157451
More information about the llvm-commits
mailing list