[PATCH] D157451: [AMDGPU] Do not deduce access qualifiers from IR attributes

[Changpeng Fang via Phabricator via llvm-commits]

cfang added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/hsa-metadata-deduce-ro-arg-v3.ll:26
 }
 
 !0 = !{i32 1, i32 1}
----------------
arsenm wrote:
> This looks like lost test coverage, need to test the access of the metadata
Under V3, if the access is default, it won't print out "default", (will not print out the access qualifier at all).

But I am curious because "noalias readonly %in", why the access is not "readonly"? Does it mean the original access qualifier got lost? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157451/new/

https://reviews.llvm.org/D157451