[llvm] d462f65 - Revert "cmake: add missing dependencies on Attributes.inc"
Jon Roelofs via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 9 10:47:01 PDT 2023
Author: Jon Roelofs
Date: 2023-08-09T10:45:11-07:00
New Revision: d462f65b8242a82d2430605a741825bf10ebaca0
URL: https://github.com/llvm/llvm-project/commit/d462f65b8242a82d2430605a741825bf10ebaca0
DIFF: https://github.com/llvm/llvm-project/commit/d462f65b8242a82d2430605a741825bf10ebaca0.diff
LOG: Revert "cmake: add missing dependencies on Attributes.inc"
This reverts commit 30b4351c7c75296dc60fc887212cdc98e85e9996.
This caused a dependency cycle that the Swift build picked up on:
```
CMake Error: The inter-target dependency graph contains the following strongly connected component (cycle):
"llvm-tblgen" of type EXECUTABLE
depends on "LLVMCodeGenTypes" (weak)
depends on "LLVMTableGenGlobalISel" (weak)
depends on "intrinsics_gen" (strong)
"LLVMTableGenGlobalISel" of type STATIC_LIBRARY
depends on "LLVMCodeGenTypes" (weak)
depends on "vt_gen" (strong)
"vt_gen" of type UTILITY
depends on "llvm-tblgen" (strong)
"autogen_intrinsics_RISCV" of type UTILITY
depends on "llvm-tblgen" (strong)
"intrinsics_gen" of type UTILITY
depends on "llvm-tblgen" (strong)
depends on "autogen_intrinsics_RISCV" (strong)
"LLVMCodeGenTypes" of type STATIC_LIBRARY
depends on "vt_gen" (strong)
```
rdar://113636528
Added:
Modified:
llvm/unittests/Analysis/CMakeLists.txt
llvm/utils/TableGen/CMakeLists.txt
Removed:
################################################################################
diff --git a/llvm/unittests/Analysis/CMakeLists.txt b/llvm/unittests/Analysis/CMakeLists.txt
index 847430bf17697a..c21ad3afa18a34 100644
--- a/llvm/unittests/Analysis/CMakeLists.txt
+++ b/llvm/unittests/Analysis/CMakeLists.txt
@@ -64,8 +64,6 @@ add_llvm_unittest_with_input_files(AnalysisTests
${ANALYSIS_TEST_SOURCES}
)
-add_dependencies(AnalysisTests intrinsics_gen)
-
target_link_libraries(AnalysisTests PRIVATE LLVMTestingSupport)
# On AIX, enable run-time linking to allow symbols from the plugins shared
diff --git a/llvm/utils/TableGen/CMakeLists.txt b/llvm/utils/TableGen/CMakeLists.txt
index fbd9f114b89b7d..bb942fb939de0f 100644
--- a/llvm/utils/TableGen/CMakeLists.txt
+++ b/llvm/utils/TableGen/CMakeLists.txt
@@ -89,9 +89,6 @@ add_tablegen(llvm-tblgen LLVM
X86RecognizableInstr.cpp
WebAssemblyDisassemblerEmitter.cpp
$<TARGET_OBJECTS:obj.LLVMTableGenCommon>
-
- DEPENDS
- intrinsics_gen # via llvm-min-tablegen
)
target_link_libraries(llvm-tblgen PRIVATE LLVMTableGenGlobalISel)
set_target_properties(llvm-tblgen PROPERTIES FOLDER "Tablegenning")
More information about the llvm-commits
mailing list