[PATCH] D157515: [GlobalISel] Also set dead flags of implicit defs added by BuildMI

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/GIMatchTableExecutorImpl.h:989
+      bool Found = false;
+      for (auto &Op : OutMIs[InsnID]->implicit_operands()) {
+        if (Op.isReg() && Op.isDef() && Op.getReg() == Register(RegNum)) {
----------------
There should be an implicit_defs() that needs no conditions inside the loop


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-lowering-swap-compare-operands.mir:99
     liveins: $x0, $x1
-    ; Arithmetic immediates can be folded into compares. If we have one, then
-    ; don't bother changing anything.
----------------
Lost comment 


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-lowering-swap-compare-operands.mir:575
 
-    ; Swap when we can see a constant folding opportunity through the sub on
-    ; the LHS.
----------------
More lost comments 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157515/new/

https://reviews.llvm.org/D157515