[PATCH] D156670: AMDGPU/GlobalISel: Handle stacksave/stackrestore

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/stacksave_stackrestore.invalid.ll:5
+
+; RUN: not --crash llc -global-isel=1 -mtriple=amdgcn-amd-amdpal -mcpu=gfx1030 -filetype=null %t/stacksave-error.ll 2>&1 | FileCheck -check-prefix=ERR-SAVE-GISEL %s
+; RUN: not --crash llc -global-isel=1 -mtriple=amdgcn-amd-amdpal -mcpu=gfx1030 -filetype=null %t/stackrestore-error.ll 2>&1 | FileCheck -check-prefix=ERR-RESTORE-GISEL %s
----------------
Pierre-vh wrote:
> nit: why does this test use `amdpal` but the MIR ones don't?
> Also is `filetype=null` needed?
We emit an error on amdgpu_gfx functions for amdhsa which is really annoying.

-filetype=null saves time by not actually emitting the broken result


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156670/new/

https://reviews.llvm.org/D156670