[PATCH] D156614: [AArch64][GISel] Handling for G_VECREDUCE_FMIN and G_VECREDUCE_FMAX

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

End to end tests should generally be preferred, especially for optimization combines. Pure MIR testing was more useful in the beginning when most stuff didn't just work. MIR tests are still useful for edge cases that should fold out ordinarily but places still need to handle them correctly

I also think we have poor MIR printer defaults. At a minimum -simplify-mir should be the default, and even that doesn't get to simple enough. The printer should learn to only print entries in the register section for register hints or other properties that aren't already expressed inline


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156614/new/

https://reviews.llvm.org/D156614