[PATCH] D157494: [SystemZ][z/OS] Add support for function name field of PPA1

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 9 06:42:19 PDT 2023


uweigand accepted this revision.
uweigand added a comment.
This revision is now accepted and ready to land.

See minor nit inline.  Otherwise LGTM.



================
Comment at: llvm/lib/Target/SystemZ/SystemZAsmPrinter.cpp:1129
+static void emitPPA1Name(const MachineFunction *MF,
+                         std::unique_ptr<MCStreamer> &OutStreamer) {
+  StringRef OutName = MF->getFunction().getName();
----------------
Please pass `OutStreamer` as first argument for consistency with `emitPPA1Flags`.  Also, just pass in a `StringRef OutName` instead of all of `MF`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157494/new/

https://reviews.llvm.org/D157494



More information about the llvm-commits mailing list