[PATCH] D157426: [AMDGPU][True16] Fix ISel for A16 Image Instructions
Ivan Kosarev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 9 05:32:53 PDT 2023
kosarev added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:5887
if (IsA16 || IsG16) {
- if (Intr->NumVAddrs > 1) {
+ if (Intr->NumVAddrs >= 1) {
SmallVector<Register, 4> PackedRegs;
----------------
kosarev wrote:
> A comment explaining why it's important to include the case of NumVAddrs == 1 might be helpful.
What are the cases where this condition is not met?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157426/new/
https://reviews.llvm.org/D157426
More information about the llvm-commits
mailing list