[PATCH] D157490: [NFC][GuardUtils] Refactor parseCondition

[Aleksandr Popov via Phabricator via llvm-commits]

aleksandr.popov created this revision.
Herald added a subscriber: hiraditya.
Herald added a project: All.
aleksandr.popov requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

parseCondition refactoring after it was extracted in D157276 <https://reviews.llvm.org/D157276>


https://reviews.llvm.org/D157490

Files:
  llvm/lib/Analysis/GuardUtils.cpp


Index: llvm/lib/Analysis/GuardUtils.cpp
===================================================================
--- llvm/lib/Analysis/GuardUtils.cpp
+++ llvm/lib/Analysis/GuardUtils.cpp
@@ -118,17 +118,16 @@
 
 template <typename CallbackType>
 static void parseCondition(Value *Condition, CallbackType Callback) {
-  SmallVector<Value *, 4> Worklist(1, Condition);
+  SmallVector<Value *> Worklist = {Condition};
   SmallPtrSet<Value *, 4> Visited;
-  Visited.insert(Condition);
   do {
     Value *Check = Worklist.pop_back_val();
+    if (!Visited.insert(Check).second)
+      continue;
     Value *LHS, *RHS;
     if (match(Check, m_And(m_Value(LHS), m_Value(RHS)))) {
-      if (Visited.insert(LHS).second)
-        Worklist.push_back(LHS);
-      if (Visited.insert(RHS).second)
-        Worklist.push_back(RHS);
+      Worklist.push_back(LHS);
+      Worklist.push_back(RHS);
       continue;
     }
     Callback(Check);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157490.548556.patch
Type: text/x-patch
Size: 925 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230809/082ff621/attachment.bin>