[PATCH] D157468: [RISCV] Add bounds check before use on returned iterator.

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 9 03:53:48 PDT 2023


asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.

Fix LGTM. I think it makes some sense to see if a simple test case can be produced as @wangpc suggests - I don't think that's always the case when there's a missing check (as test cases might end up being very specific to the current implementation approach), but it does feel like the fact you encountered this error indicates we don't have enough in-tree testing for this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157468/new/

https://reviews.llvm.org/D157468



More information about the llvm-commits mailing list