[PATCH] D155956: [FunctionAttrs] Consider recursive argmem effects (PR63936)

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:178
+                       MemoryLocation::getBeforeOrAfter(Arg, I.getAAMetadata()),
+                       ArgMR);
+        }
----------------
goldstein.w.n wrote:
> Maximum depth on recursion?
There is no recursion here.


================
Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:246
 
-  return OrigME & ME;
+  return {OrigME & ME, RecursiveArgME};
 }
----------------
goldstein.w.n wrote:
> Style on `&`
Not sure what you mean here. The `&` is a bitwise and rather than a reference, so I think the style is correct?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155956/new/

https://reviews.llvm.org/D155956