[PATCH] D156018: [BOLT] Implement createRelocation for AArch64
Jiapeng Zhou via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 9 01:17:09 PDT 2023
Kepontry marked 2 inline comments as done.
Kepontry added inline comments.
================
Comment at: bolt/lib/Core/Relocation.cpp:349-351
+ Value -= PC;
+ assert((Value & 0xfffffffff0000000ULL) == 0 &&
+ "only PC +/- 128MB is allowed for direct call");
----------------
rafauler wrote:
> What happens with this assert() when the call target is at a lower address than the call instruction? (PC > Value).
Oh, it was my mistake. This assert() now checks whether "Value(i.e., offset) + 128M" is less than 256M.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156018/new/
https://reviews.llvm.org/D156018
More information about the llvm-commits
mailing list