[PATCH] D157203: [symbolizer][NFC] Reorganize parsing input binary file

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with nits.



================
Comment at: llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp:183
+      if (HasFilePrefix || HasBuildIDPrefix)
+        // Input file specification prefix is already seen.
+        return false;
----------------
Here and below "is already seen" -> "has already been seen"


================
Comment at: llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp:197
+  }
+  if (HasBuildIDPrefix || HasFilePrefix) {
+    if (!BinaryName.empty() || !BuildID.empty())
----------------
I'd probably add a blank line before this if.


================
Comment at: llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp:199
+    if (!BinaryName.empty() || !BuildID.empty())
+      // Input file is already specified in command line.
       return false;
----------------
"is already" -> "has already been"
"in command line" -> "on the command-line"


================
Comment at: llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp:215
+    if (BinaryName.empty() && BuildID.empty()) {
+      // No input file is specified. If the input string contains at least two
+      // items, assume that the first item is a file name.
----------------



================
Comment at: llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp:219
+      if (Name.empty() || InputString.empty())
+        // No input filename is specified.
+        return false;
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157203/new/

https://reviews.llvm.org/D157203