[PATCH] D156978: [symbolizer][NFC] Move file argument parsing into separate function

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

One nit from me, otherwise LGTM too.



================
Comment at: llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp:145
+    char Quote = *Pos;
+    Pos++;
+    const char *End = strchr(Pos, Quote);
----------------
Nit: https://llvm.org/docs/CodingStandards.html#prefer-preincrement

(I know this was there before, but since you're moving the code, you might as well fix it at the same time)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156978/new/

https://reviews.llvm.org/D156978