[PATCH] D156889: [mlir][cf] Add ControlFlow to SCF lifting pass

Tue Aug 8 23:12:36 PDT 2023

gysit accepted this revision.
gysit added a comment.
This revision is now accepted and ready to land.

LGTM

Looking forward to use this!

================
Comment at: mlir/lib/Transforms/Utils/CFGToSCF.cpp:1004
+  //                  +---+    |      +---+     |
+  //                  |ret+<---+---->++   ++<---+
+  //                  +---+          |     |
----------------
zero9178 wrote:
> gysit wrote:
> > ultra nit:  Any chance there is a way to illustrate a bit better that the return is part of region1? Otherwise the graphics are super nice!
> I tried to move the `ret` block further up and moving the `Region 1` label to have about equal distance to both in the hopes of it looking clearer
nice!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156889/new/

https://reviews.llvm.org/D156889