[PATCH] D157466: Improve llvm-gsymutil performance in quiet mode.

[Greg Clayton via Phabricator via llvm-commits]

clayborg created this revision.
clayborg added reviewers: ayermolo, GeorgeHuyubo, yinghuitan, aprantl.
Herald added a subscriber: hiraditya.
Herald added a project: All.
clayborg requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The GSYM code alwasy logging to streams even in quiet mode. When in quiet mode we would use the "nulls()" stream to avoid logging to the terminal, but this still caused logging functions to be called on DWARFDie objects and other messages which were quite expensive and not needed if we weren't logging anything. This patch switches some logs in performant areas to be "raw_ostream *" values and if the ostream pointer is NULL, then we don't call the expensive logging functions on DWARFDie and other objects which will improve performance.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D157466

Files:
  llvm/include/llvm/DebugInfo/GSYM/DwarfTransformer.h
  llvm/include/llvm/DebugInfo/GSYM/ObjectFileTransformer.h
  llvm/lib/DebugInfo/GSYM/DwarfTransformer.cpp
  llvm/lib/DebugInfo/GSYM/ObjectFileTransformer.cpp
  llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp
  llvm/unittests/DebugInfo/GSYM/GSYMTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157466.548430.patch
Type: text/x-patch
Size: 20776 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230809/8a37607a/attachment.bin>