[PATCH] D156611: [llvm-cov] Fix a bug about using `convert-for-testing` on multi-source object files

Gulfem Savrun Yeniceri via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 8 17:59:12 PDT 2023


gulfem added a comment.

In D156611#4555830 <https://reviews.llvm.org/D156611#4555830>, @phosek wrote:

> This is a breaking change since it modifies the `.covmapping` format in a backwards incompatible way. For `.profdata` format we always try to avoid breaking changes and provide backwards compatibility, but I don't know if the same holds for the `.covmapping` format which is used only for testing. @davidxl do you have any thoughts on that?

@davidxl @AtomicGu is doing a GSoC project this summer, and ran into this issue in the test that he wrote in https://reviews.llvm.org/D151283. If you do not have any concern about compatibility of `.covmapping` format, can we land this change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156611/new/

https://reviews.llvm.org/D156611



More information about the llvm-commits mailing list