[PATCH] D157210: [symbolizer] Change reaction on invalid input

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 8 17:54:17 PDT 2023

Previous message: [PATCH] D156611: [llvm-cov] Fix a bug about using `convert-for-testing` on multi-source object files
Next message: [PATCH] D157210: [symbolizer] Change reaction on invalid input
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

ikudrin added a comment.

LGTM. Returning an explanatory `Error` instead of just a boolean status seems like a big improvement to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157210/new/

https://reviews.llvm.org/D157210

Previous message: [PATCH] D156611: [llvm-cov] Fix a bug about using `convert-for-testing` on multi-source object files
Next message: [PATCH] D157210: [symbolizer] Change reaction on invalid input
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list