[PATCH] D157437: AMDGPU: Expand remaining system atomic operations

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 8 17:02:38 PDT 2023


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:14166
+  case AtomicRMWInst::Add:
+    // PCIe supports add and xchg for system atomics.
+    break;
----------------
arsenm wrote:
> rampitec wrote:
> > It does not support it for system scope atomics, it just supports it.
> so what's the distinction? It's there but useless ?
'system' here is just an indicator (quite imperfect) it can go over PCIe. But the PCIe itself just supports these and does not know about scopes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157437/new/

https://reviews.llvm.org/D157437



More information about the llvm-commits mailing list