[PATCH] D157437: AMDGPU: Expand remaining system atomic operations

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 8 16:57:04 PDT 2023


arsenm added a comment.

In D157437#4571294 <https://reviews.llvm.org/D157437#4571294>, @rampitec wrote:

> It seems unfair to me, we give an option to override it for FP atomics, but not for INT.

The FP option is also broken and should be removed. There are two separate properties. We should have something for the FP properties that can be ignored on the specific instruction, and one for ignore the scope (although I don't know why the unsafe usage can't just use the wrong scope)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157437/new/

https://reviews.llvm.org/D157437



More information about the llvm-commits mailing list