[PATCH] D157358: [FunctionPropertiesAnalysis] Add detailed analysis

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.


================
Comment at: llvm/lib/Analysis/FunctionPropertiesAnalysis.cpp:90
+
+    unsigned PredecessorCount = succ_size(&BB);
+    if (PredecessorCount == 1)
----------------
`pred_size`

Is the test catching this?


================
Comment at: llvm/lib/Analysis/FunctionPropertiesAnalysis.cpp:105
+
+    for (const Instruction &I : BB) {
+      if (I.isCast())
----------------
probably want to ignore debug instructions

also, do you care if it's an intrinsic?


================
Comment at: llvm/lib/Analysis/FunctionPropertiesAnalysis.cpp:119
+          if (C->getType()->isIntegerTy())
+            IntegerConstantCount += 1;
+          else if (C->getType()->isFloatTy())
----------------
`++IntegerConstantCount`?


================
Comment at: llvm/lib/Analysis/FunctionPropertiesAnalysis.cpp:121
+          else if (C->getType()->isFloatTy())
+            FloatingPointConstantCount += 1;
+        }
----------------
`++FloatingPointConstantCount`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157358/new/

https://reviews.llvm.org/D157358