[PATCH] D156158: [LAA] Rename and fix semantics of MaxSafeDepDistBytes to MinDepDistBytes

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/include/llvm/Analysis/LoopAccessAnalysis.h:204
+  /// simultaneously.
+  uint64_t getMinDepDistBytes() { return MinDepDistBytes; }
 
----------------
Are there any uses outside of LAA remaining? If not, maybe make it private to prevent future  potential mis-use?


================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:2010
+  // since there is a backwards dependency.
+  uint64_t MaxVF = MinDepDistBytes / (TypeByteSize * Stride);
   LLVM_DEBUG(dbgs() << "LAA: Positive distance " << Val.getSExtValue()
----------------
This is the only non-NFC part of the patch, IIUC? Would it be possible to create a test case showing the new behavior?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156158/new/

https://reviews.llvm.org/D156158