[PATCH] D157358: [FunctionPropertiesAnalysis] Add detailed analysis

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 8 14:47:23 PDT 2023


mtrofin added inline comments.


================
Comment at: llvm/lib/Analysis/FunctionPropertiesAnalysis.cpp:321

----------------
aidengrossman wrote:
> mtrofin wrote:
> > why did this shift to the right?
> In the actual git diff it doesn't look like it did. https://github.com/boomanaiden154/llvm-project/commit/688dbdba8bc1b27a363f32b1d92e8fe10c21a504
> I uploaded this patch manually by copying the output from `git diff HEAD~1` and phabricator seems to be messing up the formatting for some reason (not sure why, same process worked perfectly for other patches recently).
> 
> This section of the file didn't actually change at all in the diff.
can you try again with arcanist?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157358/new/

https://reviews.llvm.org/D157358



More information about the llvm-commits mailing list