[PATCH] D156397: [FunctionAttrs] Unconditionally perform argument attribute inference in the first function-attrs pass
Changpeng Fang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 8 13:51:54 PDT 2023
cfang added a comment.
> The "or" is very declarative as opposed to imperative, which I think is more confusing. I imagine `function-attrs` as performing everything, then `<foo>` is a constraint on top of that, so something like `<skip-non-recursive-function-attrs>` makes more sense to me.
Do you mean to replace "skip-non-recursive" with "skip-non-recursive-function-attrs"? (this does not say anything about argument attribute explicitly)
Do you also want the variable name and related comments to be changed?
"bool SkipNonRecursive" for example?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156397/new/
https://reviews.llvm.org/D156397
More information about the llvm-commits
mailing list