[PATCH] D157020: [WIP][lld/ELF] Don't relax R_X86_64_(REX_)GOTPCRELX when offset is too far

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 8 13:33:10 PDT 2023


aeubanks added a comment.

we'd like to have a single configuration across all builds so that people don't have to manually specify `-Wl,--[no-]relax`
the problems with `--no-relax` are:

- increases `.rela.dyn` and `.got` section sizes
- causes regressions on some microbenchmarks

that's why I'd like to make this work in general without users having to specify flags

if we limit the extra scanning pass to cases where there may be a relocation overflow, so that it doesn't run for most normal-sized binaries, is that still a concern? if other arches already do this sort of thunk creation/relaxation I don't see why x86-64 can't do it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157020/new/

https://reviews.llvm.org/D157020



More information about the llvm-commits mailing list