[PATCH] D155732: [MC][COFF][AArch64] Avoid incorrect IMAGE_REL_ARM64_BRANCH26 relocations.

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added a comment.

> I don't think that we can directly compare what we do to masm; we support an assembler dialect which is not masm, and that includes branching where the destination is an offset from a symbol. Given that, I think we need this logic in WinCOFFObjectWriter, whether or not we emit all temporary symbols. (The change in AArch64AsmBackend.cpp is necessary either way.)

I guess the piece that I'm wondering is why we would need that if the local symbol is available because the label is preserved, the linker should be able to resolve the symbol relative offset and then discard the temporary symbol I thought.  What condition am I overlooking?

> Also, emitting all temporary symbols significantly bloats object files. (I don't have numbers at hand, but I recall it being significant.)

Oh, I completely agree with you on that point.  I wouldn't be surprised at all at it being significant.  I think that matching semantics is something we should do any way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155732/new/

https://reviews.llvm.org/D155732