[PATCH] D154725: [AggressiveInstCombine] Fold strcmp for short string literals

Alexander Kornienko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 8 12:30:06 PDT 2023


alexfh added a comment.

In D154725#4570358 <https://reviews.llvm.org/D154725#4570358>, @alexfh wrote:

> In D154725#4568911 <https://reviews.llvm.org/D154725#4568911>, @xbolva00 wrote:
>
>> This is serious, please fix or revert from release branches.
>
> I'll prepare a revert in case @kitaisreal doesn't respond soon.
>
> Here a slightly more convenient reproducer (dumped IR right before the AggressiveInstCombine pass): https://gcc.godbolt.org/z/bGn3EnWG6

The commit can't be reverted cleanly, I'll have to also revert dependent commits: cbfcf90152de5392a36d0a0241eef25f5e159eef <https://reviews.llvm.org/rGcbfcf90152de5392a36d0a0241eef25f5e159eef> and 5dde755188e34c0ba5304365612904476c8adfda <https://reviews.llvm.org/rG5dde755188e34c0ba5304365612904476c8adfda>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154725/new/

https://reviews.llvm.org/D154725



More information about the llvm-commits mailing list