[PATCH] D147740: [llvm-profdata] Refactoring Sample Profile Reader to increase FDO build speed using MD5 as key to Sample Profile map
Aaron Ballman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 8 12:10:08 PDT 2023
aaron.ballman added a comment.
In D147740#4570400 <https://reviews.llvm.org/D147740#4570400>, @huangjd wrote:
> @antmo @DavidSpickett @aaron.ballman
> Are you able to check if the latest version fixed the issues on ARM-32? I do not have access to ARM-32 machine but was able to reproduce the same failing test cases in Win32 and fixed it. I would like to confirm it's working before landing the patch again
I don't have access to an ARM machine myself; I only noticed the issue through the build farm. If you think the code is working, I think it's fine to land it again to see if the bots agree -- it's pretty normal to not have access to all the same hardware as the bots, so speculative commits are somewhat routine.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147740/new/
https://reviews.llvm.org/D147740
More information about the llvm-commits
mailing list