[PATCH] D157144: [VPlan] Replace FMF in VPInstruction with VPRecipeWithIRFlags (NFC).

[Ayal Zaks via Phabricator via llvm-commits]

Ayal accepted this revision.
Ayal added a comment.
This revision is now accepted and ready to land.

Looks good to me! Adding couple of final minor nits.



================
Comment at: llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp:235
+                             std::initializer_list<VPValue *> Operands,
+
+                             FastMathFlags FMFs, DebugLoc DL, const Twine &Name)
----------------
nit: redundant empty line


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp:399
   assert(!State.Instance && "VPInstruction executing an Instance");
   IRBuilderBase::FastMathFlagGuard FMFGuard(State.Builder);
+  if (hasFastMathFlags()) {
----------------
nit: this is if and only if, can assert(hasFastMathFlags() == isFPMathOp() && "...").


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157144/new/

https://reviews.llvm.org/D157144