[PATCH] D156397: [FunctionAttrs] Unconditionally perform argument attribute inference in the first function-attrs pass

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 8 09:45:29 PDT 2023


aeubanks added a comment.

sorry for the late response

as I keep saying, the test is still not really a phase ordering test because it's not exercising the entire pipeline, you're printing the IR very early on in the pipeline, but you should be printing the IR at the very end of the pipeline: `opt -O3 -S < %s`. please find a test that is a proper phase ordering test and also is affected by this func-attrs change


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156397/new/

https://reviews.llvm.org/D156397



More information about the llvm-commits mailing list