[PATCH] D157230: [SPARC][IAS] Add SETX pseudoinstruction

[Sergei Barannikov via Phabricator via llvm-commits]

barannikov88 added inline comments.


================
Comment at: llvm/lib/Target/Sparc/AsmParser/SparcAsmParser.cpp:659
+  if (!is64Bit())
+    return Error(IDLoc, "setx is only available in 64-bit mode");
+
----------------
koakuma wrote:
> barannikov88 wrote:
> > Looks like dead code (MatchInstructionImpl should return Match_MissingFeature). Can you add a test for this as in D144936?
> > 
> It should be unreachable, yes, but for some reason it still gets through even though I've already specified `Requires<[Is64Bit]>` in the SETX definition.
> Any idea how to properly fix this?
`Requires<[HasV9]>` should work (the predicate must be derived from AssemlerPredicate).



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157230/new/

https://reviews.llvm.org/D157230