[PATCH] D154987: [lit] Implement PYTHON directive and config.prologue

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 8 08:23:29 PDT 2023

jdenny added a comment.

In D154987#4568886 <https://reviews.llvm.org/D154987#4568886>, @jhenderson wrote:

>> In D154987#4539229 <https://reviews.llvm.org/D154987#4539229>, @awarzynski wrote:
>>> In D154987#4531662 <https://reviews.llvm.org/D154987#4531662>, @jhenderson wrote:
>>>> I think it would be worth outlining in this patch why simply calling an external python script (which could actually be embedded within the file) is insufficient for the motivating case.
>>> +1
>> I just extended `TestingGuide.rst`.  Let me know if it's not what you are looking for.
> Thanks. In my case at least, I was just referring to enhancing the commit description or even just posting a review comment with the explanation. Enhancing the documentation works for me though.

Thanks for taking a look (and the typo correction).  Hopefully having it in the docs will help if this point continues to be raised, and it might help users choose between `%python` and `PYTHON`.



More information about the llvm-commits mailing list