[PATCH] D155299: [AArch64][SVE2] Combine add+lsr to rshrnb for stores

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.

Thanks. LGTM



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:20083
+// a uzp1 or a truncating store.
+static SDValue trySimplifySrlAddToRshrnb(const SDValue *Srl, SelectionDAG &DAG,
+                                         const AArch64Subtarget *Subtarget,
----------------
SDValue is usually passed by value, not as a pointer. It might also be able to generate the DL from `SDLoc DL(Srl);`, depending on where it is best for the debug loc to come from.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155299/new/

https://reviews.llvm.org/D155299