[PATCH] D156491: [RA] Split a virtual register in cold blocks if it is not assigned preferred physical register

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added inline comments.


================
Comment at: llvm/lib/CodeGen/RegAllocGreedy.cpp:2404
+  if (!NewVRegs.empty())
+    return 0;
 
----------------
qcolombet wrote:
> Splitting decisions are supposed to be taken later (`trySplit`), this breaks the general algorithm's flow.
Concretely, I'm asking if you could do this kind of splitting in the splitting heuristic.
You may want to add a new stage in the algorithm (and that'll come at a compile time cost.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156491/new/

https://reviews.llvm.org/D156491