[PATCH] D157204: [MLIR][Math] Add support for f16 in the expansion of math.roundeven

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 8 02:54:23 PDT 2023


qcolombet added inline comments.


================
Comment at: mlir/lib/Dialect/Math/Transforms/ExpandPatterns.cpp:321
+  unsigned mantissaWidth =
+      llvm::cast<FloatType>(operandETy).getFPMantissaWidth() - 1;
+  unsigned exponentWidth = bitWidth - mantissaWidth - 1;
----------------
Why the `-1` here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157204/new/

https://reviews.llvm.org/D157204



More information about the llvm-commits mailing list