[PATCH] D154725: [AggressiveInstCombine] Fold strcmp for short string literals

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 8 02:49:11 PDT 2023


nikic added a comment.

I believe the problem is that if the constant string is on the LHS, we also need to invert the greater/smaller results. The current code would be correct for equality comparisons, but not for relational comparisons.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154725/new/

https://reviews.llvm.org/D154725



More information about the llvm-commits mailing list