[PATCH] D155484: [AArch64] Global Isel Funnel Shift Lowering

[Dave Green via Phabricator via llvm-commits]

dmgreen added a reviewer: arsenm.
dmgreen added inline comments.
Herald added a subscriber: wdng.


================
Comment at: llvm/include/llvm/Target/GlobalISel/Combine.td:387
+// Fold x op 0 -> x
+def fourth_identity_zero: GICombineRule<
+  (defs root:$root),
----------------
Can you split this out into a separate patch (and move it down next to funnel_shift_to_rotate, maybe with a name that includes funnel_shift). It could do with a mir test to show the combine works in isolation. It's probably best to keep the optimization separate from the legalization though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155484/new/

https://reviews.llvm.org/D155484