[PATCH] D157300: [lld-macho]Rework error-checking in peeking at first-member in archive to avoid segfault.
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 7 17:58:06 PDT 2023
MaskRay added a comment.
> calling getMemoryBufferRef() on an empty archive can sometimes trigger segfault so the code should check before calling this. this seems like a bug in the Archive API but that can be fixed separately.
Is there a test case? When is "sometimes"?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157300/new/
https://reviews.llvm.org/D157300
More information about the llvm-commits
mailing list