[PATCH] D156429: [TableGen] Add new bang operator !format

Michael Maitland via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 7 16:04:26 PDT 2023


michaelmaitland added a comment.

In D156429#4567088 <https://reviews.llvm.org/D156429#4567088>, @tra wrote:

> When functions/lambdas are available, they would provide a better way to implement D156432 <https://reviews.llvm.org/D156432> examples, IMO. I suspect it would obviate the need for `!format`.

The purpose of this patch, as @wangpc states, is to capture the ability to concatenate code strings. IMO we should go with the simplest and most straightforward approach. Maybe we should prefer lambdas/functions over format since the semantics for format is a particularly complex and non-standard one when we look at different languages (i.e. escaping, named args, positional args, formatters), while lambdas and functions are relatively more universal.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156429/new/

https://reviews.llvm.org/D156429



More information about the llvm-commits mailing list