[PATCH] D157272: [RISCV] Handle subregs when folding vmerge into vops

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 7 14:51:14 PDT 2023


reames added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:3354
+  // TargetConstant:i32<4>
+  //   t40: v2i32 = COPY_TO_REGCLASS t41, TargetConstant:i64<22>
+  //     t41: nxv1i32,ch = PseudoVLE32_V_MF2 ...
----------------
I'm looking at this, and am trying to understand why we get the COPY_TO_REGCLASS here.  If I'm reading this right, we should be generating this only when doing a insert_subreg between two equally LMUL-sized register groups.  Given that, I think we must have had two insert_subregs originally, and shouldn't one of have been combined away?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157272/new/

https://reviews.llvm.org/D157272



More information about the llvm-commits mailing list