[PATCH] D156049: [SPIR-V] Remove -opaque-pointers=0 from LITs, fixes for opaque pointers support

Mon Aug 7 13:58:49 PDT 2023

bogner added inline comments.

================
Comment at: llvm/lib/Target/SPIRV/SPIRVGlobalRegistry.cpp:751
+             getSPIRVTypeID(SpirvType));
+    else
+      DT.add(Ty->getNonOpaquePointerElementType(), Ty->getPointerAddressSpace(),
----------------
`isOpaquePointerTy` is deprecated and just returns `isPointerTy` as of [[ https://github.com/llvm/llvm-project/commit/2ea5aa1c96cfb15ece9a665f0d59d6c9fa1365f0 | 2ea5aa1c96cf ]], so the else branch here (and in other similar cases) is unreachable and can be removed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156049/new/

https://reviews.llvm.org/D156049