[PATCH] D155617: [WIP] GSoC 2023: Pass to annotate functions with appropriate optimization level.

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/FunctionAnnotator.cpp:27
+  auto memoryBuffer = MemoryBuffer::getMemBuffer(Buffer);
+  line_iterator itr(*memoryBuffer, false);
+  for (Function &F : M) {
----------------
Puneeth-A-R wrote:
> mtrofin wrote:
> > mtrofin wrote:
> > > nit: why SkipBlanks=false? (fine by me, the csv is for test - just curious) 
> > Itr (first letter must be capital)
> > 
> > we tend to call iterators "I" or "It"
> I wonder why... just a convention or is there a specific reason?
The "first letter capital" is coding convention (https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly)

The name itself is more like what became, arguably, convention - and it's easier to read by others if we follow it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155617/new/

https://reviews.llvm.org/D155617