[PATCH] D157299: [RISCV] Use vmv.s.x for a constant build_vector when the entire size is less than 32 bits

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 7 12:28:07 PDT 2023


reames added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:3301
+        SplatValue |= ((cast<ConstantSDNode>(SeqV)->getZExtValue() & EltMask)
+                       << (EltIdx * EltBitSize));
+      EltIdx++;
----------------
luke wrote:
> Are EltIdx and Idx the same?
Looks like it.  Will fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157299/new/

https://reviews.llvm.org/D157299



More information about the llvm-commits mailing list