[PATCH] D157313: [ValueTracking] Check likely to be canonicalized constant operands first in ; NFC

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:2109
+    return isKnownToBeAPowerOfTwo(I->getOperand(2), OrZero, Depth, Q) &&
+           isKnownToBeAPowerOfTwo(I->getOperand(1), OrZero, Depth, Q);
   case Instruction::PHI: {
----------------
goldstein.w.n wrote:
> nikic wrote:
> > Does this canonicalization actually exist?
> No. Happy to drop but think its not difference either way.
I dropped the select changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157313/new/

https://reviews.llvm.org/D157313