[PATCH] D157302: [ValueTracking] Compute `sdiv` as non-zero if `abs(num) u>= abs(denum)`
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 7 11:49:28 PDT 2023
nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:2570
+ // If X is fully unknown we won't be able to figure anything out so don't
+ // both compuring knownbits for Y.
+ if (!XKnown.isUnknown()) {
----------------
computing
================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:2571
+ // both compuring knownbits for Y.
+ if (!XKnown.isUnknown()) {
+ KnownBits YKnown =
----------------
Pre existing, but this should be an early return false.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157302/new/
https://reviews.llvm.org/D157302
More information about the llvm-commits
mailing list