[PATCH] D157303: [ValueTracking] Add tests for more `isKnownToBeAPowerOfTwo` cases; NFC

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 7 11:26:48 PDT 2023


nikic added inline comments.


================
Comment at: llvm/test/Analysis/ValueTracking/known-power-of-two.ll:335
+  ret i1 %r
+}
+
----------------
It would be good to add a negative test for non-rotate funnel shift (i.e. both args being pow2 does not imply the result being pow2 in that case).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157303/new/

https://reviews.llvm.org/D157303



More information about the llvm-commits mailing list