[PATCH] D157290: [InstCombine] Fold (-a >> b) and/or (~a >> b) into (-a and/or ~a) >> b

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:995
+      }
+    }
+
----------------
Imo the LHS/RHS logic are similiar enough it should be a lambda. Will make the code a lot cleaner.


================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:1009
+      return Result;
+  }
 
----------------
This codeblock needs some comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157290/new/

https://reviews.llvm.org/D157290