[PATCH] D157295: [RISCV] Lower vro{l,r} for fixed vectors

Luke Lau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 7 10:03:36 PDT 2023


luke added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:5021
   case ISD::ROTR:
+    if (Subtarget.hasStdExtZvbb())
+      return lowerToScalableOp(Op, DAG);
----------------
craig.topper wrote:
> Don't we need to check for vector type here?
Yep, forgot to check that


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157295/new/

https://reviews.llvm.org/D157295



More information about the llvm-commits mailing list